Bug 149877 - Track changes color coding inconsistent; moved has sometimes the same color as deleted in macOS
Summary: Track changes color coding inconsistent; moved has sometimes the same color a...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2022-07-06 03:38 UTC by Telesto
Modified: 2024-05-30 17:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-07-06 03:38:57 UTC
Description:
Track changes color coding inconsistent; moved has sometimes the same color as deleted

Steps to Reproduce:
1. Open attachment 180483 [details]
2. Tools -> Options -> Make sure user date being empty (close dialog with OK)
3. Enable track changes: Edit -> Track changes -> Record (show changes should be enabled)
3. Select the "six" in the first line
4. Backspace -> Text strike through, yellow (expected)
5. Select "ways" next to six in the first line
6. CTRL+X
7. CTRL_V -> Strike through, yellow -> UN-expected (reference: step 8-10)
8. Select "idolatry" in the first line
9. CTRL+X -> Text strike through, yellow (expected)
10. CTRL+V -> Text strike through, green (expected)
11. Press CTRL+Z once -> Text strike through, green (UN-expected, expected yellow)


Actual Results:
Moved gets the color coding of deleted

Expected Results:
Proper color coding


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 7a89eae97a970939174d59aa58147eaa194acaee
CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 1 Roman Kuznetsov 2022-07-08 17:42:02 UTC
>7. CTRL_V -> Strike through, yellow -> UN-expected (reference: step 8-10)

I got the green color in this step

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 41139aa86ecbb4c34e9996eb0f95a194b8eb0771
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

possibly mac only problem?
Comment 2 Telesto 2022-07-08 19:04:36 UTC
(In reply to Roman Kuznetsov from comment #1)
> >7. CTRL_V -> Strike through, yellow -> UN-expected (reference: step 8-10)
> 
> I got the green color in this step
> 
How did you select "six" "ways" in step 3/5? I used double click in both cases (forgot to mention this before)
Comment 3 Roman Kuznetsov 2022-07-08 19:45:54 UTC
(In reply to Telesto from comment #2)
> (In reply to Roman Kuznetsov from comment #1)
> > >7. CTRL_V -> Strike through, yellow -> UN-expected (reference: step 8-10)
> > 
> > I got the green color in this step
> > 
> How did you select "six" "ways" in step 3/5? I used double click in both
> cases (forgot to mention this before)

The same method
Comment 4 Telesto 2022-07-08 20:46:32 UTC
I will check it again, maybe a build glitch
Comment 5 Telesto 2022-07-09 09:24:20 UTC
The same with TDF master build (previously was my own build)
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: c1c8ce3b0f1037bca4d500af2f39363cd9d38db6
CPU threads: 8; OS: Mac OS X 12.3.1; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 6 Roman Kuznetsov 2022-07-09 10:59:57 UTC
confirm in macOS

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: c1c8ce3b0f1037bca4d500af2f39363cd9d38db6
CPU threads: 4; OS: Mac OS X 12.4; UI render: Skia/Metal; VCL: osx
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded

Lazslo, you made many changes in this area in last time. Could you please look at it?
Comment 7 Stéphane Guillou (stragu) 2024-05-24 02:16:12 UTC
Telesto, can you please check if this was resolved by the fix for bug 149388?
Comment 8 Telesto 2024-05-24 05:50:42 UTC
(In reply to Stéphane Guillou (stragu) from comment #7)
> Telesto, can you please check if this was resolved by the fix for bug 149388?

I guess so. I should have added a screenshot for the previous state. It's still not totally fine though, I think. All modification are shown in yellow. There is no color coding; feels off. I need to check it on a Windows machine for comparison.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: aef28c23adc87b8e26eacb56c7dbcf652e907fb9
CPU threads: 8; OS: macOS 14.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

FWIW: I assume it to be bug 149388; however didn't carefully check.. so that's why opted for WFM. Feel free to change it
Comment 9 Stéphane Guillou (stragu) 2024-05-24 06:01:04 UTC
(In reply to Telesto from comment #8)
> It's
> still not totally fine though, I think. All modification are shown in
> yellow. There is no color coding; feels off. I need to check it on a Windows
> machine for comparison.
I think that's the expected default for addition vs deletion. Underline and strikethrough are used to differentiate between them.
However, is a move also yellow, i.e. when drag-and-fropping a text selection to a different location? That should be the dark green one.
> FWIW: I assume it to be bug 149388; however didn't carefully check.. so
> that's why opted for WFM. Feel free to change it
Makes perfect sense, thank you!
Comment 10 Telesto 2024-05-30 11:37:25 UTC
(In reply to Stéphane Guillou (stragu) from comment #9)
> However, is a move also yellow, i.e. when drag-and-fropping a text selection
> to a different location? That should be the dark green one.

A change is only registered as: Insert or delete as far my testing goes. I'm unable to create change which registers as 'move' in LibreOffice (drag drop is registered as deletion and insertion). The sample document shows an 'move' but no clue how to do that (no recent version of MSO at hand for testing)

This  isn't specific for Mac, also happening on Win.


Regarding to the color scheme. I still find it odd that empty user data the insertion color being yellow on Mac and blue on Windows. I would somewhat expect the same behaviour across all system environments (already for the sake of testing).
Comment 11 Stéphane Guillou (stragu) 2024-05-30 17:50:15 UTC
(In reply to Telesto from comment #10)
> A change is only registered as: Insert or delete as far my testing goes. I'm
> unable to create change which registers as 'move' in LibreOffice (drag drop
> is registered as deletion and insertion). The sample document shows an
> 'move' but no clue how to do that (no recent version of MSO at hand for
> testing)
It is inconsistent for me too. A drag-and-drop will sometimes result in addition/deletion in yellow, sometimes in a dark green move. Might need a new report for that.
 
> Regarding to the color scheme. I still find it odd that empty user data the
> insertion color being yellow on Mac and blue on Windows. I would somewhat
> expect the same behaviour across all system environments (already for the
> sake of testing).
Probably better to track that in bug 149953.