Description: Misspelled word is not marked this way after undo of suggestion Steps to Reproduce: 1. Open attachment 164442 [details] 2. Right click "nervously" and replace it with Wonderfull (assuming German Dictionary 3. CTRL+Z 4. Notice "nervously" not being misspelled.. You need to type something to trigger the red underlining Kind of annoying if you picked the wrong item in the list.. Actual Results: No dirty flag (misspelled) straight away Expected Results: Ideally yes Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d5e55d204b71710eb5eb5d2c683dd6698626df3c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL still fine with Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL
Also in Version: 7.1.0.0.beta1+ (x64) Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL not in 7.0
Created attachment 175299 [details] Bibisect log Bisected to: author Michael Stahl <Michael.Stahl@cib.de> 2020-08-19 18:55:27 +0200 committer Michael Stahl <michael.stahl@cib.de> 2020-08-20 13:47:08 +0200 commit ec579354af954867b829e7d08e4d752518c83728 (patch) tree e2fea1fd4729fedf648f129a0e927674b4235c7a parent 6274fbe13c8fa556916b5aed695c6921ef6ff84f (diff) tdf#135721 sw: fix spell check context menu deleting flys Kind of similar to e1629c210ad78310e3d48c0756723134a27b89df but the problem is at a higher level: SwTextShell::Execute() with SID_SPELLCHECK_APPLY_SUGGESTION should not DelLeft() + Insert() but just Replace(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) https://cgit.freedesktop.org/libreoffice/core/commit/?id=ec579354af954867b829e7d08e4d752518c83728
Tested with Version: 7.2.2.2 (x64) / LibreOffice Community Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Mispelled words are only underlined after right click. So the problem you describe is in line with a more general problem(Automatic Spell Checking is enabled, but doesn't seem to work correct)
(In reply to Dieter from comment #3) Is this a conformation? Or..
Tested again with Version: 7.3.0.3 (x64) / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Steps to Reproduce: 1. Open attachment 164442 [details]. Document language is German. None of the words is marked as misspelled (for me that is not expected) 2. Right click "nervously" => words are marked as misspelled 3. Replace "vervously" with "wundervoll" 4. CTRL+Z 5. "nervously" not being misspelled. If you click right, is is marked as misspelled again. Conclusion Behaviour in step 5 is in line with step 1. So either behaviour in step 1 is the bug (I think so) or it's the expected behaviour.
Reproducible for me with both current master and version 7.3.4.0.0+ Version: 7.3.4.0.0+ / LibreOffice Community Build ID: f668663d63d5b0f37d4727b54585c3b67ab92162 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_20.04_x86-64 Calc: threaded Set status at NEW. Best regards. JBF
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The problem here is that the undone/redone content isn't selected. Compare the new Undo behavior, which doesn't select the restored "nervously", with what happens when you e.g. type "foo bar" then three backspaces then Ctrl+Z. In the latter case, the restored "foo" gets selected. Before the fix to bug 136294, the selection wouldn't be enough to get the underline back. Now it should work. https://gerrit.libreoffice.org/c/core/+/168423
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/31f46cec1406bb39453f5d909da1321980b0e405 tdf#144752: UNDO/REDO: make sure to select the replaced content It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/258c34bddb0a1da09a3bb0ccccf2bd673be377b1 tdf#144752: UNDO/REDO: make sure to select the replaced content It will be available in 24.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.