Bug 126095 - NB Impress/Draw: "Drawing" toolbar visible which should be hidden for notebookbar view when apply-to-all done in another app
Summary: NB Impress/Draw: "Drawing" toolbar visible which should be hidden for noteboo...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:24.8.0 target:24...
Keywords:
: 122087 139624 141369 147516 147800 156341 (view as bug list)
Depends on:
Blocks: Toolbars Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2019-06-25 23:12 UTC by andreas_k
Modified: 2024-06-04 10:30 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-06-25 23:12:49 UTC
Description:
the following toolbars are visible which should be not visible, cause the functionality is already in the different notebookbar implementations

impress
- master toolbar
- table toolbar


draw
- master toolbar
- table toolbar
- media toolbar
- 

Steps to Reproduce:
1. clear profile
2. use tabbed NB
3. select context to show the specific toolbars

Actual Results:
show toolbars

Expected Results:
don't show toolbars cause NB has the functionality


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 andreas_k 2019-06-25 23:13:58 UTC Comment hidden (obsolete)
Comment 2 Buovjaga 2019-11-12 12:25:05 UTC
Let's set to NEW
Comment 3 QA Administrators 2023-04-01 03:23:21 UTC Comment hidden (obsolete, spam)
Comment 4 Justin L 2023-06-16 18:10:55 UTC
*** Bug 147800 has been marked as a duplicate of this bug. ***
Comment 5 Justin L 2023-06-16 18:11:48 UTC
*** Bug 122270 has been marked as a duplicate of this bug. ***
Comment 6 Justin L 2023-06-16 18:13:15 UTC
*** Bug 147516 has been marked as a duplicate of this bug. ***
Comment 7 Justin L 2023-06-16 18:15:27 UTC
*** Bug 139624 has been marked as a duplicate of this bug. ***
Comment 8 Justin L 2023-06-16 19:52:56 UTC
*** Bug 141369 has been marked as a duplicate of this bug. ***
Comment 9 Justin L 2023-06-19 20:35:26 UTC
In sfx2/source/appl/appserv.cxx SID_TOOLBAR_MODE, it saves the current list of toolbars into UserToolbars, and disables all toolbars - BUT ONLY FOR THE CURRENT APPLICATION. This is why the Draw/Impress toolbars are not disabled during "Apply to All"

private:resource/toolbar/toolbar is a UserToolbar that is configured by default as true in
officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu

So that is why the long toolbar shows up by default. Also DrawWindowState.xcu. 

The 4-button presentation toolbar shows up because DrawViewShell::ChangeEditMode turns it on for Impress when not in Master or Handout mode.
Comment 10 Commit Notification 2023-06-20 14:49:24 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1ff817faad79952e6271bab178d41cae2a0d9ecd

tdf#126095 impress notebookbar: don't force Master/Presentation toolbars

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Justin L 2023-06-20 15:03:30 UTC
Comment 10's patch fixes the small presentation toolbar (View - toolbars - presentation) with New/Duplicate/Delete/Layout slide from showing up in Impress.

The bigger Drawing toolbar (View - Toolbars - Drawing) I don't know how to solve properly. It is being loaded in Impress/Draw, but if we default it to false (as suggested in comment 9), then it loads as not visible for the "default" menu, which of course must not happen.

Basically, it needs to default off, but be added as a UserToolbar in the config. Or else we need to completely ignore the configmgr and just always show it in the default menu.

But probably the best solution is to leave it as it is. The user who is annoyed just has to turn it off once, and it will stay off.

But I'll leave the bug report open in case anyone wants to fix it.
Comment 12 Pedro 2023-06-20 16:10:48 UTC Comment hidden (no-value)
Comment 13 Pedro 2023-06-20 16:11:31 UTC Comment hidden (no-value)
Comment 14 Pedro 2023-06-20 16:13:23 UTC Comment hidden (no-value)
Comment 15 Pedro 2023-06-20 16:31:03 UTC Comment hidden (no-value)
Comment 16 Pedro 2023-06-24 10:27:44 UTC
Tested in latest dev release in safe mode without user profile, selecting Tabbed UI and observed the following:
1 - Drawing and Standard toolbar do not appear any longer.
2 - Master Toolbar and Table toolbar do no appear any longer as well.
3 - Master Toolbar and Table toolbar do not appear in Draw any longer.
Comment 17 Stéphane Guillou (stragu) 2023-07-17 14:48:56 UTC
Justin, any chance you could you do the same for the table toolbar that pops up when a table is selected in Draw/Impress?

It still pops up with:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 46d7119b8be03968017e59d882e5671350304e15
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

(In reply to Pedro from comment #16)
> Tested in latest dev release in safe mode without user profile, selecting
> Tabbed UI and observed the following:
> 1 - Drawing and Standard toolbar do not appear any longer.
> 2 - Master Toolbar and Table toolbar do no appear any longer as well.
> 3 - Master Toolbar and Table toolbar do not appear in Draw any longer.

Pedro, did you test by turning the Tabbed UI on _from outside Draw/Impress_ ? Because when doing that, I can still see the Table toolbar pop up when a table is selected, and the Drawing toolbar always displayed.
Comment 18 Rafael Lima 2023-07-17 23:50:09 UTC
(In reply to Stéphane Guillou (stragu) from comment #17)
> Justin, any chance you could you do the same for the table toolbar that pops
> up when a table is selected in Draw/Impress?

I guess this would fix bug 142489 as well.
Comment 19 Commit Notification 2023-07-18 00:27:23 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1de07de0cb063760474df70d0e4b6a7976ac2a8a

related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBox

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2023-07-18 00:34:26 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e58e251756ecb0312cb6891d4df23e17ef8f6fcb

tdf#126095 sd notebookbar: don't force table/media toolbar

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Justin L 2023-07-18 00:39:12 UTC
(In reply to Stéphane Guillou (stragu) from comment #17)
> Justin, any chance you could you do the same for the table toolbar that pops
> up when a table is selected in Draw/Impress?

The first three are now avoided:

graphicobjectbar: for calc/writer the default is to be visible, but for draw/impress, it is set to be not visible
officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
 <node oor:name="private:resource/toolbar/graphicobjectbar" oor:op="replace">
    <prop oor:name="Visible" oor:type="xs:boolean"><value>false</value>

mediaobjectbar: for draw it is visible, but for impress it is not visible

tableobjectbar: for draw/impress it is visible


These remaining ones are not impacted. Perhaps they should be if they are visible...

textobjectbar: for draw/impress it is not visible
   -(connected with a table, but not with a textbox)

extrusionobjectbar (3d stuff) for draw/impress it is visible (I don't know how to trigger this - inserting a 3-d object doesn't call it.)

fontworkobjectbar: for draw/impress it is visible (but I don't see it coming up. It DOES come up for the regular menu. So how is notebookbar suppressing this one?)

bezierobjectbar: for draw/impress it is visible (but I don't know how to trigger this)
Comment 22 Stéphane Guillou (stragu) 2023-07-18 06:46:25 UTC
*** Bug 156341 has been marked as a duplicate of this bug. ***
Comment 23 Stéphane Guillou (stragu) 2023-07-18 06:52:03 UTC
Setting severity back to "normal" given the number of duplicates.

I will test soon with a build that includes your patches but we might have to eventually close this one and open follow-up reports for remaining issues.
Thanks Justin!
Comment 24 Justin L 2023-08-21 18:27:49 UTC
*** Bug 122087 has been marked as a duplicate of this bug. ***
Comment 25 Commit Notification 2024-05-23 00:27:19 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cdbd4139790383052f004def482f32fdec604fbb

Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Justin L 2024-05-23 00:51:10 UTC
comment 20 was reverted by comment 25 because of regression bug 161212.
Comment 27 Commit Notification 2024-05-23 07:42:19 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/5777b30375df6b34568cf88cc3701513635eace1

Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"

It will be available in 24.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Commit Notification 2024-06-04 10:30:45 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-24-2-4":

https://git.libreoffice.org/core/commit/df737dc40e47322f1d6f2a3a3fbd08373125eafd

Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.