| Summary: | DOCX comments (replies) are in the wrong order | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Justin L <jluth> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jluth, timur |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 4.3 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=160350 | ||
| Whiteboard: | target:24.8.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 112916 | ||
| Attachments: | commentsInWordD.docx: this hand-crafted version isn't solved, but that is out of scope. | ||
|
Description
Justin L
2024-04-24 18:45:19 UTC
The order they appear in word/comments.xml is the order in which they should appear in the document as well (at least for this example). Based on reading the 4.3 patch's writerfilter code, I don't see anything that would change the order. Indeed, it still calls PopAnnotation in this order: 0 // First coment (note that the 1 is from list numbering - which is lost in LO) 1 // 1.1 second reply. 3 // 1.2 third reply. Only reply on whole thread… 5 // 1.3 2 // 2. second comment 4 // 2.1 If I disable NS_ooxml::LN_EG_RangeMarkupElements_commentRangeEnd (so there is no range, just a single entry point) then the comments are back in the right order. So the problem is related to the fact that w:commentRangeEnd w:id="2/3/4"/> comes before <w:commentReference w:id="3"/> is inserted. Thus the remaining comments (2 and 4) try to import into SwPaM start[SwPosition (node 9, offset 10)] mark[SwPosition (node 9, offset 10)] A wild attempt at a fix is at https://gerrit.libreoffice.org/c/core/+/166765 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7ae84ed99b133cdb4c197ecb43e2454f90b0439a tdf#160814 writerfilter: insert comment after other comments It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e7ea91a4af1242fcfa5f5ba5f04bbc6662453e28 tdf#160814 writerfilter: insert comment after other comments #2 It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 194014 [details]
commentsInWordD.docx: this hand-crafted version isn't solved, but that is out of scope.
|