Summary: | Crash if change in formatting in Writer by converting text to table with field variable | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | gerhard.schaden |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | critical | CC: | gerhard.schaden, michael.stahl, raal, samuel.mehrbrodt, serval2412, stephane.guillou |
Priority: | medium | Keywords: | bibisected, bisected, haveBacktrace, regression |
Version: | 7.3.3.2 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
Crash report or crash signature: | ["GoPreviousWithFrame(SwNodeIndex*, SwFlowFrame const**)"] | Regression By: | Michael Stahl |
Bug Depends on: | |||
Bug Blocks: | 103100 | ||
Attachments: |
Minimal document to reproduce the bug
gdb bt |
Description
gerhard.schaden
2023-07-18 11:21:55 UTC
Created attachment 188430 [details]
Minimal document to reproduce the bug
To reproduce the bug:
1. Select the text with the mouse
2. TABLE > CONVERT > TEXT TO TABLE
3. Click OK
Just to be clear: LibreOffice Writer can crash in both safe and normal mode. The only difference is that in one condition, Writer crashes when "Equal width for all columns" is selected; in the other, Writer crashes when "Equal width for all columns" is DEselected. Created attachment 188434 [details]
gdb bt
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Michael: noticing 9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749 sw: fix expansion of SetGetExpField in headers with split table rows thought you might be interested in this one. I got the crash report https://crashreport.libreoffice.org/stats/crash_details/b6ecde21-c74a-4367-937a-5d89c9df6ddb with: Version: 7.4.7.2 / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded The setting "Equal width for all columns" does not matter, I was able to reproduce regardless of it with: 1. open attachment 188430 [details] 2. Table > convert > text to table > OK 3. Ctrl + z 4. Table > convert > text to table > OK Also happens in: Version: 7.3.7.2 / LibreOffice Community Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Regression as not reproduced in: Version: 7.2.7.2 / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded This seems to have begun at the below commit in bibisect repository/OS linux-64-7.5$. Adding Cc: to Samuel Mehrbrodt ; Could you possibly take a look at this one? Thanks ae083ec6a3ce351a0fd8884d8c5e762ddd4b6c37 is the first bad commit commit ae083ec6a3ce351a0fd8884d8c5e762ddd4b6c37 Author: Jenkins Build User <tdf@pollux.tdf> Date: Mon Apr 3 08:28:14 2023 +0200 source c8e9df0b583e8a61a0570f72c0a476a5102f1fe9 148957: Always update fields when loading document | https://gerrit.libreoffice.org/c/core/+/148957 Thanks raal, but you bibisected to 7.5 when we could reproduce in 7.3. Which steps did you use? (In reply to Stéphane Guillou (stragu) from comment #7) > Thanks raal, but you bibisected to 7.5 when we could reproduce in 7.3. > Which steps did you use? Steps from comment 1 Bibisected with comment 5 steps with linux-64-7.3 repo to first bad commit e22741875593ab5feeec486c916f03780e05ad81 which points to core commit 855e2af1bf6eb216d63ca7baeb9161c7cd501a42 which is a cherrypick of: commit 9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749 author Michael Stahl Tue Apr 05 18:27:35 2022 +0200 committer Michael Stahl Wed Apr 06 19:51:19 2022 +0200 sw: fix expansion of SetGetExpField in headers with split table rows Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132641 ... which confirms what Julien suspected in comment 4. Even quicker steps: 1. open attachment 188430 [details] 2. Ctrl + A 3. Table > convert > text to table > OK 4. Ctrl + Z 5. Ctrl + Y Michael, can you please have a look? (In reply to Stéphane Guillou (stragu) from comment #9) > 1. open attachment 188430 [details] > 2. Ctrl + A > 3. Table > convert > text to table > OK > 4. Ctrl + Z > 5. Ctrl + Y > > Michael, can you please have a look? I had another look, and as raal mentioned already, 7.5, 7.6 and 24.2 now all crash on step 3. Thanks raal for that! I can confirm the start of that with the linux-64-7.5 repo to first bad commit ae083ec6a3ce351a0fd8884d8c5e762ddd4b6c37 which points to core commit c8e9df0b583e8a61a0570f72c0a476a5102f1fe9 which is a cherrypick of: commit c132a1abd57c109331191c3b3fbd14e1c5e46631 author Samuel Mehrbrodt Mon Mar 06 17:00:10 2023 +0100 committer Samuel Mehrbrodt Mon Mar 13 20:12:52 2023 +0000 Always update fields when loading document Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148355 Not sure if this should be reported separately. Michael and Samuel, can you please have a look? Happy to open a separate report if needed. |