Summary: | Memory usage keeps increasing for every change in the column width | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Telesto <telesto> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ilmari.lauhakangas, vmiklos |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 6.2.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | Windows (All) | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=119820 https://bugs.documentfoundation.org/show_bug.cgi?id=119992 |
||
Whiteboard: | target:6.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103100 | ||
Attachments: | Bibisect log |
Description
Telesto
2018-09-19 18:49:34 UTC
Created attachment 145107 [details] Bibisect log Bisected to: author Miklos Vajna <vmiklos@collabora.co.uk> 2018-08-31 18:19:12 +0200 committer Miklos Vajna <vmiklos@collabora.co.uk> 2018-09-03 09:13:32 +0200 commit aeff83240c88435d11590f5e9c6fe9927a508c6a (patch) tree a3b918a7d3164ee428a4df39df7118a87618dfd9 parent 08b5048198d59441cb8033ed14cd17e68c943004 (diff) sw: save more vcl layout calls in SwFntObj This builds on top of commit 436b829f5b904d76039db0818cff5dedf1ae89f1 (sw: save one vcl layout call in SwFntObj::DrawText(), 2018-08-16), but now layouts are shared not only inside SwFntObj::DrawText(), but also between SwFntObj::GetTextSize() and SwFntObj::DrawText(). To get there, create an SwFntObj cache member that stores already calculated vcl layouts. SwFntObj already derives from SwCacheObj, so no need to explicitly expire this cache member. Total number of GenericSalLayout::LayoutText() invocations go down from 8 to 5 with this when pressing a key in Writer. https://cgit.freedesktop.org/libreoffice/core/commit/?id=aeff83240c88435d11590f5e9c6fe9927a508c6a @Buovjaga Would you mind to verifier this one (and ideally bug 119992; same file different issue) some time. I prefer to give quick feedback (while memory about the code is still fresh), instead of letting in linger in the bug tracker. Repro. Step 2: Tools - Options - LibreOffice - Advanced - Open expert config: search for "steps" and scroll to bottom, double-click Undo and set value to 0. Adding Cc: to Miklos Vajna Version: 6.2.0.0.alpha0+ (x64) Build ID: 3208fcb3a36d75d6290d9c548430682f153b09db CPU threads: 4; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-20_22:43:20 Locale: fi-FI (fi_FI); Calc: threaded Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5da57ff00b23fd9969a2bfcf4e6e1e8245dfc1a3 tdf#119993 sw: clear the font cache text glyphs on table col change It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |