| Summary: | FILEOPEN DOCX: Mark as Final property not read | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Gabor Kelemen (allotropia) <kelemeng> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aron.budea, penzes_david |
| Priority: | medium | Keywords: | filter:docx |
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=120852 | ||
| Whiteboard: | interoperability target:6.2.0 target:6.1.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 104520 | ||
| Attachments: |
Example file marked as final
Example file in Word 2013 Same document in current Writer master patch |
||
|
Description
Gabor Kelemen (allotropia)
2017-05-07 21:55:47 UTC
Created attachment 133142 [details]
Example file in Word 2013
Created attachment 133143 [details]
Same document in current Writer master
Confirmed in 5.3.3.2 and 3.3.0 / Windows 7. ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug This property is opened correctly, see "_MarkAsFinal" on File->Properties->Custom Properties page, moreover, it's possible to switch off it before saving.
Unfortunately, This property is not a standard DOCX property. MS Office uses a custom property to store it, see in docProp/custom.xml:
<property fmtid="{D5CDD505-2E9C-101B-9397-08002B2CF9AE}" pid="9" name="_MarkAsFinal"><vt:bool>1</vt:bool></property>
It seems, D5CDD505-2E9C-101B-9397-08002B2CF9AE is a "predefined property set format identifier" of Microsoft for "The DocumentSummaryInformation and UserDefined Property Sets": https://msdn.microsoft.com/en-us/library/windows/desktop/aa380060(v=vs.85).aspx
Unfortunately, it seems, this is not the same, as "Read-only document", ie. DocSecurity=1 "Document is recommended to be opened as read-only." or DocSecurity=2 "Document is enforced to be opened as read-only." (ECMA 22.2.2.7 DocSecurity (Document Security)), see in docProp/app.xml:
<DocSecurity>0</DocSecurity>
So it's hard to handle this in a correct way, because neither MS Office does it.
> Interesting fact that checking this box on a new document, saving it as docx and opening it in Word activates the correct warning that says this document is marked as final.
This is possible, if the default empty document template was replaced by an ODT document containing this custom property (which comes from a DOCX document).
Created attachment 142963 [details] patch patch: tdf#107690 Initial support of Mark as Final property of MSO Don't save modified documents with property _MarkAsFinal=True silently to avoid to get unintended warning messages in MSO. Show read-only info bar for documents with custom document property _MarkAsFinal=True, similar to MSO. This improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. In gerrit: https://gerrit.libreoffice.org/#/c/56180/ NOTE: OOXML DocSecurity doesn't supported by MSO 2016, only this _MarkAsFinal. NOTE II: Missing info bar for LO LoadReadonly property (associated to read-only document property) is likely an ugly regression from LO 6.0. It needs to fix it to solve this issue in the proposed way. László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a5c56a9c4e04589b0a6bb710573922e459d9685 tdf#107690 OOXML import/export of setting "Open as read-only" It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. László Németh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbdb6cb8ed0d77eeb2e413b38f29d2084bd8257b tdf#107690 DOCX, XLSX and PPTX unit tests for "Open as read-only" It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. László Németh committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=61aaefd8e902f86f5f7347efdb56686638149133&h=libreoffice-6-1 tdf#107690 OOXML import/export of setting "Open as read-only" It will be available in 6.1.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |