Summary: | Can not edit interior table border style more than once (without un/re-selecting) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jim Avera <jim.avera> |
Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | michael.stahl, telesto, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 4.1 all versions | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=60513 | ||
Whiteboard: | target:5.4.0 target:5.3.3 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103100 | ||
Attachments: |
bugdemo.odt (see "Steps to reproduce")
Screen shot showing 2nd time Properties is opened |
Description
Jim Avera
2017-04-03 16:44:20 UTC
Created attachment 132312 [details]
bugdemo.odt (see "Steps to reproduce")
Created attachment 132313 [details]
Screen shot showing 2nd time Properties is opened
This problem does occur. I followed the procedure above and the outcome was a predicted. It only happen when table is selected. When you select select a cell and open table properties and make changes to interior border this is not the case Confirming with: Version: 5.4.0.0.alpha0+ CPU threads: 4; OS: Windows 6.19; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2017-04-05_23:32:27 Locale: nl-NL (nl_NL); Calc: CL and with Versie: 4.4.6.3 Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d Locale: nl_NL and with Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 but not with: Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 Regression introduced by: author Michael Stahl <mstahl@redhat.com> 2013-03-27 22:09:59 (GMT) committer Michael Stahl <mstahl@redhat.com> 2013-03-27 22:47:00 (GMT) commit b227a8e4d65e4bbfe991aed9342fe3e30eca8639 (patch) tree 64ca9d8b92092739385bf64a8ff97a067f8350b7 parent 159edc43135bd02f6d507424c3b0546c2e03851f (diff) fdo#60513: SwCrsrShell::Push(): take position from table cursor If there is a table cursor, store its point/mark position on the cursor stack instead of pCurCrsr, which in this case is just one cell in a ring that contains a SwShellCrsr for every selected cell. SwCrsrShell::Pop() is surprisingly able to restore the prior state, because it calls UpdateCrsr(), which detects that the pCurCrsr spans multiple table cells and re-creates pTblCrsr, and then later on the first GetCrsr() call SwTableCursor::MakeBoxSels() will restore the ring of SwShellCrsrs from the pTblCrsr selection. Bisected with bibisect-41max. Adding Cc: to Michael Stahl fixed on master Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c72b9c1dc5683a132bf00659e0c8556253340c97 tdf#106929 sw: SwCursorShell::Pop() ensure cursor ring is recreated It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0ae1b76c3a90226ba588eb75837ab2f494ac5d5f&h=libreoffice-5-3 tdf#106929 sw: SwCursorShell::Pop() ensure cursor ring is recreated It will be available in 5.3.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Confirmed fixed in Version: 5.3.4.0.0+ Build ID: 221de7cfdb6c6b6a4879162652bf842c4358f9eb and in master. Thank you very much! |